Hold onto authorization header with ApiToken source #1599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the `AuthenticationSource::ApiToken` variant to hold onto the authorization header that may be used to fetch the current user.
|
@sgrif please take a look 😄 |
|
☔ The latest upstream changes (presumably #1610) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I've used your changes, made some improvements and moved things a little further forward. I'd love your feedback. It is PR #1700. |
|
I'm really sorry about the long delay on this, but I've resolved the merge conflicts and this looks great! Thank you! @bors r+ |
|
📌 Commit dec4383 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 4, 2019
Hold onto authorization header with ApiToken source Modify the `AuthenticationSource::ApiToken` variant to hold onto the authorization header that may be used to fetch the current user. Ref. #1548 (Task 4)
|
💔 Test failed - checks-travis |
|
@bors r+ |
|
📌 Commit 8e3d345 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 5, 2019
Hold onto authorization header with ApiToken source Modify the `AuthenticationSource::ApiToken` variant to hold onto the authorization header that may be used to fetch the current user. Ref. #1548 (Task 4)
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
AuthenticationSource::ApiTokenvariant to hold onto the authorization header that may be used to fetch the current user.Ref. #1548 (Task 4)