Skip to content

controllers/krate/delete: prevent any crates with rdeps from deletion #10591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

LawnGnome
Copy link
Contributor

Temporary hack while we discuss #10538 further.

Here's what this now looks like on the deletion page:

image

Feel free to bikeshed exactly what we include in there. (Do we need the GitHub issue?)

This should be a straightforward revert depending on what we decide.

@LawnGnome LawnGnome added C-bug 🐞 Category: unintended, undesired behavior A-frontend 🐹 A-backend ⚙️ labels Feb 14, 2025
@LawnGnome LawnGnome self-assigned this Feb 14, 2025
@LawnGnome LawnGnome force-pushed the temp-block-rdep-deletion branch from dc5b996 to 73ffe91 Compare February 14, 2025 18:37
@LawnGnome LawnGnome requested a review from a team February 14, 2025 18:47
@LawnGnome LawnGnome marked this pull request as ready for review February 14, 2025 18:47
Copy link
Member

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@Turbo87 Turbo87 merged commit dca6e84 into rust-lang:main Feb 15, 2025
11 checks passed
LawnGnome added a commit to LawnGnome/crates.io that referenced this pull request Mar 7, 2025
LawnGnome added a commit that referenced this pull request Mar 7, 2025
controllers/krate/delete: remove the temporary language from #10591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants