Skip to content

Upgrading ember-source from 3.1.2 to 3.15.0 breaks logging in #2028

Closed
@carols10cents

Description

@carols10cents

When I try to log in, I get an invalid state parameter error.

See #2001 and #2027.

I'm going to be updating this with more details as I figure them out.


Ok, I don't know how much of this is related or not, but I'm going to err on the side of over-posting.


fsevents can't install (not likely related)

When I run npm install lately (on master as well), I see a bunch of errors and ultimately it says npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.11. Seeing as this is an optional dependency, I don't think this is causing the problem, but I haven't been seeing these errors until recently so I decided to list it just in case.

Might be related to an update to macOS I installed recently, but brew doctor isn't complaining about anything. Skimming through fsevents' issues seems like the recommended solution is upgrading to fsevents 2+.

Full error logs

stderr:

$ npm install

> fsevents@1.2.11 install /Users/carolnichols/rust/crates.io/node_modules/fsevents
> node-gyp rebuild

No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'.

No receipt for 'com.apple.pkg.DeveloperToolsCLILeo' found at '/'.

No receipt for 'com.apple.pkg.DeveloperToolsCLI' found at '/'.

gyp: No Xcode or CLT version detected!
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/Users/carolnichols/.nvm/versions/node/v12.13.1/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:351:16)
gyp ERR! stack     at ChildProcess.emit (events.js:210:5)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Darwin 19.2.0
gyp ERR! command "/Users/carolnichols/.nvm/versions/node/v12.13.1/bin/node" "/Users/carolnichols/.nvm/versions/node/v12.13.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/carolnichols/rust/crates.io/node_modules/fsevents
gyp ERR! node -v v12.13.1
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok
npm WARN ajv-keywords@3.4.1 requires a peer of ajv@^6.9.1 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.11 (node_modules/fsevents):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.11 install: `node-gyp rebuild`
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1

updated 1 package and audited 258667 packages in 36.505s

17 packages are looking for funding
  run `npm fund` for details

found 32 vulnerabilities (2 low, 6 moderate, 24 high)
  run `npm audit fix` to fix them, or `npm audit` for details

Error proxying

Ok, yeah, I just got this to happen on fd70920. I sign out, and when I sign in, it works but I see this in the logs:

Full error logs
GET /api/private/session/begin 200 22.560 ms - 179
Error proxying to http://127.0.0.1:8888
socket hang up


Stack Trace and Error Report: /var/folders/qc/0ry2bjtd7wd9q8r1c7wylplr0000gn/T/error.dump.d98c1ccbcd64003184453fe7cac72e91.log
GET /authorize/cargo.png - - ms - -
GET /api/private/session/authorize?code=[redacted]&state=[redacted] 200 420.833 ms - 454

Contents of the log file:

=================================================================================

ENV Summary:

  TIME: Fri Dec 20 2019 16:58:51 GMT-0500 (Eastern Standard Time)
  TITLE: ember
  ARGV:
  - /Users/carolnichols/.nvm/versions/node/v12.13.1/bin/node
  - /Users/carolnichols/rust/crates.io/node_modules/.bin/ember
  - serve
  - --proxy
  - http://127.0.0.1:8888
  EXEC_PATH: /Users/carolnichols/.nvm/versions/node/v12.13.1/bin/node
  TMPDIR: /var/folders/qc/0ry2bjtd7wd9q8r1c7wylplr0000gn/T
  SHELL: /bin/bash
  PATH:
  - /Users/carolnichols/.nvm/versions/node/v12.13.1/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin
  - /Users/carolnichols/rust/crates.io/node_modules/.bin
  - /Users/carolnichols/.rvm/gems/ruby-2.4.1/bin
  - /Users/carolnichols/.rvm/gems/ruby-2.4.1@global/bin
  - /Users/carolnichols/.rvm/rubies/ruby-2.4.1/bin
  - /Users/carolnichols/.cargo/bin
  - /Users/carolnichols/.cargo/bin
  - /Users/carolnichols/bin
  - /Users/carolnichols/.nvm/versions/node/v12.13.1/bin
  - /usr/local/bin
  - /usr/bin
  - /bin
  - /usr/sbin
  - /sbin
  - /usr/local/MacGPG2/bin
  - /Users/carolnichols/.rvm/bin
  - /Users/carolnichols/.rvm/bin
  PLATFORM: darwin x64
  FREEMEM: 1213878272
  TOTALMEM: 17179869184
  UPTIME: 114009
  LOADAVG: 5.50732421875,6.2060546875,5.5029296875
  CPUS:
  - Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz - 3100
  - Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz - 3100
  - Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz - 3100
  - Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz - 3100
  ENDIANNESS: LE
  VERSIONS:
  - ares: 1.15.0
  - brotli: 1.0.7
  - cldr: 35.1
  - http_parser: 2.8.0
  - icu: 64.2
  - llhttp: 1.1.4
  - modules: 72
  - napi: 5
  - nghttp2: 1.39.2
  - node: 12.13.1
  - openssl: 1.1.1d
  - tz: 2019c
  - unicode: 12.1
  - uv: 1.33.1
  - v8: 7.7.299.13-node.16
  - zlib: 1.2.11

ERROR Summary:

  - broccoliBuilderErrorStack: [undefined]
  - code: ECONNRESET
  - codeFrame: [undefined]
  - errorMessage: socket hang up
  - errorType: [undefined]
  - location:
    - column: [undefined]
    - file: [undefined]
    - line: [undefined]
  - message: socket hang up
  - name: Error
  - nodeAnnotation: [undefined]
  - nodeName: [undefined]
  - originalErrorMessage: [undefined]
  - stack: Error: socket hang up
    at connResetException (internal/errors.js:570:14)
    at Socket.socketCloseListener (_http_client.js:380:25)
    at Socket.emit (events.js:215:7)
    at Socket.EventEmitter.emit (domain.js:475:20)
    at TCP.<anonymous> (net.js:659:12)

=================================================================================

I really don't know why it's requesting /authorize/cargo.png. That's not a valid path.

I'm not convinced this is related because:

  • logging in works even when I see this error
  • it doesn't happen every time i log in
  • it happens even without upgrading ember-source

Bisecting ember-source upgrades

3.15 bad
3.14
3.13
3.12 - 3.12.2 bad
3.11
3.10 - 3.10.2 bad
3.9 - 3.9.1 good
3.8 - 3.8.3 good
3.7
3.6
3.5
3.4
3.3
3.2
3.1 good

I'm not sure if I'm doing the bisecting right because I'm not resetting between each one so all the dependencies aren't getting downgraded....

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions