Description
Proposal
Extract the StableHasher
(struct), StableHasherResult
(trait) and SipHasher128
(struct) from rustc_data_structures
into their own (new) crate rustc-stable-hash
, similar to rustc-hash
, so they can be used by other projects.
In particular, this would be useful for Cargo, which needs a cross-platform independent stable hasher for the trim-paths feature, rust-lang/cargo#13171 (comment).
The plan is to create a separate repo rustc-stable-hash
(already done), create the infra1, import those parts1, publish the crate, use the new crate in rustc_data_structures
.
Mentors or Reviewers
My-self, @Urgau.
Process
The main points of the Major Change Process are as follows:
- File an issue describing the proposal.
- A compiler team member or contributor who is knowledgeable in the area can second by writing
@rustbot second
.- Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a
-C flag
, then full team check-off is required. - Compiler team members can initiate a check-off via
@rfcbot fcp merge
on either the MCP or the PR.
- Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a
- Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.
You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.