Enable unadjusted_on_win64 for UEFI in some cases
#486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conversion functions from i128/u128 to f32/f64 have the `unadjusted_on_win64` attribute, but it is disabled starting with LLVM14. This seems to be the correct thing to do for Win64, but for some reason x86_64-unknown-uefi is different, despite generally using the same ABI as Win64.
|
I'm really not at all sure why the ABI of these particular intrinsics would need to be different between Win64 and x86_64-unknown-uefi, but I have verified with a test UEFI program that this change fixes the conversions. |
|
@nikic Any idea what's going on with the ABI here? I thought UEFI was supposed to act just like Windows with regards to |
|
I think this happens because we declare uefi as a soft-float target: https://llvm.godbolt.org/z/3846ExoPz |
|
So is this a bug in LLVM? Or should this PR be merged? |
|
This is probably an LLVM bug, but at the same time we don't particularly care what the actual ABI here is, so I think it's fine to merge this. |
|
Thanks for checking on that and connecting it to soft-float :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conversion functions from i128/u128 to f32/f64 have the
unadjusted_on_win64attribute, but it is disabled starting with LLVM14. This seems to be the correct thing to do for Win64, but for some reason x86_64-unknown-uefi is different, despite generally using the same ABI as Win64.