Add GNU gcc and binutils #10
Conversation
|
We can merge this when the MCP requested in rust-lang/rust#138699 (comment) is approved 👍 |
|
No problem. Thank you! Note that GCC 8.4 is already used by Illumos: https://github.com/rust-lang/rust/blob/a932eb36f8adf6c8cdfc450f063943da3112d621/src/ci/docker/scripts/illumos-toolchain.sh#L42 as well as binutils. Though I proposed here newer version. |
|
oh, I see 👍 |
MCP was approved (rust-lang/compiler-team#870). Can you please merge this now? |
|
tests aren't passing. can you fix them and force push? |
Do you have any idea what can be wrong with it? |
|
Sometimes (more like quite frequently) the GCC servers are unreliable, IIRC they are mirrored for cg_gcc for this exact reason (tho I might be misremembering) |
Done. Can you please pull it now? |
| [[files]] | ||
| name = "rustc/gcc-8.4.0.tar.xz" | ||
| source = "https://bigsearcher.com/mirrors/gcc/releases/gcc-8.4.0/gcc-8.4.0.tar.xz" | ||
| sha256 = "e3a06e52d1e01f27ed55104ad233c3b0d1e99cfb5ff98ab022dc941edd1b2dd4" |
There was a problem hiding this comment.
I downloaded gcc-8.4.0.tar.xz and the sha doesn't correspond. What am I doing wrong? 🤔
$ sha256 gcc-8.4.0.tar.gz
SHA256 (gcc-8.4.0.tar.gz) = 41e8b145832fc0b2b34c798ed25fb54a881b0cee4cd581b77c7dc92722c116a8
There was a problem hiding this comment.
Not sure. But it must be something wrong on your side. Is it really tar archive?
The only problem I'm confused is that sha256sum tells me:
e30a6e52d10e1f27ed55104ad233c30bd1e99cfb5ff98ab022dc941edd1b2dd4
While your CI thinks it's:
e3a06e52d1e01f27ed55104ad233c3b0d1e99cfb5ff98ab022dc941edd1b2dd4
^^ (swaped characters?!)
There was a problem hiding this comment.
I downloaded the tar from https://gcc.gnu.org/pub/gcc/releases/gcc-8.4.0/gcc-8.4.0.tar.xz not the mirror.
Can you calculate the sha256 on your laptop of the release on the gnu website?
There was a problem hiding this comment.
I downloaded the tar from https://gcc.gnu.org/pub/gcc/releases/gcc-8.4.0/gcc-8.4.0.tar.xz not the mirror. Can you calculate the sha256 on your laptop of the release on the gnu website?
I already did it. It's the same as from mirror site.
There was a problem hiding this comment.
oh, I downloaded .gz instead of .xz
I also have swapped characters locally. not sure why
as requested at rust-lang/rust#138699 (comment)