-
Notifications
You must be signed in to change notification settings - Fork 302
Use relative urls everywhere. #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since all urls are now relative, you can just open site/index.html directly without having to spawn a web server.
@pietroalbini - Are you the right person to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broadly looks okay, but I'd like to hold off on merging away from a release day (since we're likely to have heavier than typical traffic today) in case there's any problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those urls seem to be hardcoded in the posts themselves:
blog.rust-lang.org/posts/2016-08-10-Shape-of-errors-to-come.md Lines 185 to 189 in 245723c
They will still work on the website. This PR doesn't change that. |
That's fine. I just think this means that there is still a reason to use a web server locally (albeit a small one), and so we should probably reference that in the README by saying that the use of the web server is optional and most everything will work without it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking this as approved because I don't want to block. I still think that the readme should continue to mention using the webserver as an optional way to view the blog locally since there are things that won't work when opening files directly in the browser.
It seems like |
Another option would be to generate a |
See #980 |
This makes it work to just open
site/index.html
in a browser locally without having tot spin up a web server.