add const generics blog post #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
approved these changes
Feb 11, 2021
|
cc @rust-lang/core -- this looks good to me, perhaps folks want to take a look? It'd be good to get it merged soon. |
camelid
reviewed
Feb 19, 2021
|
This looks good to me -- I'm thinking maybe let's merge this Wednesday (the 24th), unless some more problems are found? I'd be happy to do that if @lcnr you wanted to update the date on the post. |
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
|
seems good to me |
camelid
reviewed
Feb 22, 2021
|
@Mark-Simulacrum can we go ahead and merge this? And if so, should I update the date of the post again, or can you quickly do that? |
|
Yeah, sorry, forgot about this - will bump date and merge later today. |
Mark-Simulacrum
approved these changes
Feb 26, 2021
varkor
reviewed
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first draft written by @varkor and me.
cc @rust-lang/project-const-generics @rust-lang/lang