Blog for Rust 1.50.0 #771
Merged
Blog for Rust 1.50.0 #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about |
camelid
reviewed
Jan 28, 2021
tesuji
reviewed
Jan 28, 2021
Co-authored-by: Camelid <camelidcamel@gmail.com> Co-authored-by: Jacob Lifshay <programmerjake@gmail.com> Co-authored-by: lzutao <15225902+lzutao@users.noreply.github.com>
posts/2021-02-11-Rust-1.50.0.md
Outdated
| which variant is valid (they don't drop any old value on assignment), so | ||
| safe Rust has limited this to `Copy` types only, which never `Drop`. Of | ||
| course, that's also true of `ManuallyDrop`, so now Rust 1.50 allows safe | ||
| assignments to these fields as well. |
There was a problem hiding this comment.
Can we split the first sentence of this paragraph up? I think it's carrying a lot of weight right now in a relatively short space and would be nice to add some breaks for readers.
There was a problem hiding this comment.
I split and rearranged this a bit.
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
camelid
reviewed
Feb 9, 2021
Co-authored-by: Camelid <camelidcamel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @rust-lang/release @rust-lang/core