Skip to content

Create 2021-01-19-changes-to-rustdoc-team.md #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jan 19, 2021

@GuillaumeGomez GuillaumeGomez requested a review from a team January 19, 2021 13:10
@GuillaumeGomez
Copy link
Member Author

Ok, now waiting for reviews. :)

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super sweet ❤️ thank you!

@GuillaumeGomez
Copy link
Member Author

Updated!

Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Joshua said, this is very sweet ❤️

@GuillaumeGomez
Copy link
Member Author

Updated!

@GuillaumeGomez GuillaumeGomez merged commit ef5264b into master Jan 20, 2021
@GuillaumeGomez GuillaumeGomez deleted the rustdoc-changes branch January 20, 2021 12:25

[Joshua](https://github.com/jyn514) has been helping me **a lot** on the leading parts by tagging issues and mentoring newcomers. But at the same time, he initiated great changes in the rustdoc codebase that led to huge performance improvements, he finished the "intra doc link" features which is now stable after years of instability (more information [here](https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html)). He also did multiple additional things but let's stop the listing here. :)

Overall, he's been an enormous help and making him co-lead is just making offical everything's he's been doing since he joined the rustdoc team (and even before!). I'm glad to have him on the team and as co-lead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo

Suggested change
Overall, he's been an enormous help and making him co-lead is just making offical everything's he's been doing since he joined the rustdoc team (and even before!). I'm glad to have him on the team and as co-lead.
Overall, he's been an enormous help and making him co-lead is just making official everything's he's been doing since he joined the rustdoc team (and even before!). I'm glad to have him on the team and as co-lead.

Copy link
Member

@jyn514 jyn514 Jan 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I opened #765.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants