Add inside-rust-reviewers as reviewers for inside-rust #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealprof
approved these changes
Aug 31, 2020
Manishearth
approved these changes
Aug 31, 2020
|
Small note: I wish GitHub let you silence codeowner review notifications only, a team lead probably does not want to be pinged for review about a post from a team that's not theirs |
|
@Manishearth This could be solved by adding team subfolders, and having codeowners match that to the team leads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the CODEOWNERS for the inside rust blog to request a review from
@rust-lang/inside-rust-reviewersinstead of@rust-lang/leads. Theinside-rust-reviewersmarker team has all team leads and project group leads as membership.