Skip to content

Link to RSS feeds #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2020
Merged

Link to RSS feeds #677

merged 4 commits into from
Sep 3, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Aug 25, 2020

Fixes #420.

@camelid camelid requested a review from a team as a code owner August 25, 2020 23:19
@camelid
Copy link
Member Author

camelid commented Aug 25, 2020

Replacement of #671.

@XAMPPRocky
Copy link
Member

Thank you for your PR! Could you also include a screenshot of the change?

@camelid
Copy link
Member Author

camelid commented Aug 26, 2020

image

I don't love the placement; I think it might be better at the bottom of the page, but there wasn't anything existing there so I wasn't sure how I would set it up. Let me know if you have an idea on better placement!

@camelid
Copy link
Member Author

camelid commented Aug 26, 2020

And this is what the "Inside Rust" blog looks like:

image

@pietroalbini
Copy link
Member

Random idea:

2020-08-26--21-22-59

@camelid
Copy link
Member Author

camelid commented Aug 26, 2020

Hmm, that's interesting! Although there's already something in that column in the footer:

image

@XAMPPRocky
Copy link
Member

I would add it as a another row inside the social column, since RSS is a social technology that people use to share our content, and I know I typically look for RSS with the rest of the social icons. I think it should maybbe look something along the lines like below.

Screenshot 2020-08-26 at 22 25 59

Screenshot 2020-08-26 at 22 26 25

@camelid
Copy link
Member Author

camelid commented Aug 26, 2020

That looks good!

@rbtcollins
Copy link

Perhaps use the RSS radar icon ?

@camelid
Copy link
Member Author

camelid commented Aug 27, 2020

@XAMPPRocky How did you get that layout? I tried this but it doesn't look quite right:

      <div class="four columns mt3 mt0-l">
        <div>
          <h4>Social</h4>
          <a href="https://twitter.com/rustlang" target="_blank" rel="noopener" alt="twitter link"><img src="/images/twitter.svg" alt="twitter logo" title="Twitter"/></a>
          <a href="https://www.youtube.com/channel/UCaYhcUwRBNscFNUKTjgPFiA" target="_blank" rel="noopener" alt="youtube link"><img style="padding-top: 6px; padding-bottom:6px" src="/images/youtube.svg" alt="youtube logo" title="YouTube"/></a>
          <a href="https://discord.gg/rust-lang" target="_blank" rel="noopener" alt="discord link"><img src="/images/discord.svg" alt="discord logo" title="Discord"/></a>
          <a href="https://github.com/rust-lang" target="_blank" rel="noopener" alt="github link"><img src="/images/github.svg" alt="github logo" title="GitHub"/></a>
        </div>
        <br>
        <div>
          <h4>RSS</h4>
          <a href="/feed.xml">Main Blog</a><br>
          <a href="/inside-rust/feed.xml">"Inside Rust" Blog</a>
        </div>
      </div>

image

@XAMPPRocky
Copy link
Member

I just added a h4 with the mv3 class and an unordered list. Well more accurately I just copy pasted the ul from get help into the column.

Screenshot 2020-08-27 at 23 41 11

Thanks to @XAMPPRocky, who came up with this layout!
@camelid
Copy link
Member Author

camelid commented Aug 27, 2020

Thanks, that fixed it! Pushed up the commit.

@camelid
Copy link
Member Author

camelid commented Sep 2, 2020

Do you want to merge this? It looks like this:

image

@XAMPPRocky
Copy link
Member

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit b0b3626 into rust-lang:master Sep 3, 2020
@camelid camelid deleted the link-to-rss branch September 3, 2020 17:33
jackh726 pushed a commit to jackh726/blog.rust-lang.org that referenced this pull request Jul 26, 2021
* Link to RSS feeds

* Move RSS links to footer

Thanks to @XAMPPRocky, who came up with this layout!

* Use a flex row around social icons

* Increase top margin for RSS header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call out RSS feeds for the main and the Inside Rust blogs
4 participants