Skip to content

Announcing Rust 1.29 #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Announcing Rust 1.29 #268

merged 2 commits into from
Sep 13, 2018

Conversation

steveklabnik
Copy link
Member

r? @rust-lang/core

@Mark-Simulacrum
Copy link
Member

Cc @rust-lang/release

* `cargo fix` can automatically fix your code that has warnings
* `cargo clippy` is a bunch of lints to catch common mistakes and improve your Rust code

### `cargo fix`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be amazing if these could be contributed to the cargo docs and/or link to the cargo docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cargo docs don't have this yet. I'll put it on my to-do list.

features: they're new abilities that Cargo has grown, and they're both about lints.

* `cargo fix` can automatically fix your code that has warnings
* `cargo clippy` is a bunch of lints to catch common mistakes and improve your Rust code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably a product call that is not worth debating on this PR, but both of these deal with lints... we might want to specify that cargo fix won't fix cargo clippy lints (i am assuming that is tru)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this is specified on line 147-148.

@pietroalbini
Copy link
Member

The post is missing cargo doc --document-private-items, can you add it? We forgot to include it in the release notes too, but there is already a PR open.

@petrochenkov
Copy link
Contributor

Proc macro API was also stabilized in 1.29.

@XAMPPRocky
Copy link
Member

XAMPPRocky commented Sep 12, 2018

@petrochenkov Talking @Mark-Simulacrum users won't actually be able to use proc macros despite the API being stable.

@petrochenkov
Copy link
Contributor

@Aaronepower
I was talking about the library part, not #[proc_macro]/#[proc_macro_attribute] definitions.
Proc macro derives are stable and can use the API now instead of parsing strings.

@Mark-Simulacrum
Copy link
Member

In conversations with @alexcrichton it was my understanding that this cycle's stabilization with proc macros aren't quite as interesting as the next cycle's functionality for most end-users which is primarily why we're not really pushing it publicly; if that's not the case we can add it here I guess.

@steveklabnik
Copy link
Member Author

steveklabnik commented Sep 12, 2018

proc_macro

Yes; that's why I didn't include it. I'd rather spend time explaining it all in the next release.

The post is missing cargo doc --document-private-items, can you add it? We forgot to include it in the release notes too, but there is already a PR open.

Yes!

@Mark-Simulacrum Mark-Simulacrum merged commit d79fdb3 into gh-pages Sep 13, 2018
@Mark-Simulacrum Mark-Simulacrum deleted the 1.29-announcement branch September 13, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants