Skip to content

1.27.2 announcement #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Conversation

Mark-Simulacrum
Copy link
Member

r? @steveklabnik
cc @rust-lang/core @rust-lang/release

@pietroalbini
Copy link
Member

We should add a section about the recent increase of points releases (mostly the improvements to the release process, but also the maintenance problems of the current borrow checker).

There were a few questions on internals and reddit when we first talked about 1.27.2 on the safety/stability of the language with all those patches, and I expect even more when the actual release happens.


This patch release fixes a bug in the borrow checker verification of `match` expressions. This bug
was introduced in 1.26.0 with the stabilization of [match ergonomics]. Specifically, it permitted
code which took two mutable borrows of the `bar` path at the same time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this sentence I would expect to see something called bar and some mutable borrows in the code below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, thanks. Maybe copy/pasting the file from 1.26.2 wasn't the best idea...

@Mark-Simulacrum
Copy link
Member Author

Pushed fixes.

Would appreciate review on the discussion of reasoning for increased patch releases.

compiler and core teams required to make a patch release is greatly reduced, which also makes such a
patch release more likely to happen. The current borrow checker has been around for years now, and
is beginning to show its age. The work on a better, more precise borrow checker is underway,
and it has detected all of these bugs. This work is planned to be stabilized in the 2018 edition, so
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not mentioned the 2018 edition at all in this venue; we shouldn't reference it until we announce it, IMO. So just

This work is planned to be stabilized in the next few releases

IMO

Users have expressed concern with the frequency of patch releases to fix bugs in the match
ergonomics verification by the current borrow checker on a variety of Rust's forums. There are two
primary reasons for the increased rate of patch releases: significantly higher bandwidth and the
age of the currently used borrow checker. First off, with the formation of a Release team, Rust's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use a list for "release team"/"borrow checker"? This paragraph is huge.

@Mark-Simulacrum
Copy link
Member Author

Split up paragraph and removed note about edition, though we have talked about in the roadmap post I agree it might be best not to mention it.

@Mark-Simulacrum Mark-Simulacrum merged commit 3b29132 into rust-lang:gh-pages Jul 20, 2018
@Mark-Simulacrum Mark-Simulacrum deleted the 272 branch July 20, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants