Skip to content

Add "crates.io: development update" blog post #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 29, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jul 22, 2024

r? @rust-lang/crates-io

@Turbo87 Turbo87 added the content An issue related to an article. label Jul 22, 2024
@marcoieni
Copy link
Member

marcoieni commented Jul 22, 2024

Consider adding a closing paragraph where you invite people to write in zulip to leave their feedback.
In the document you mentioned multiple times that you want the user feedback, but maybe they don't know where to send it 👍

I enjoyed reading the article, thanks for putting it together 🙌
None of my comments are blocking of course 👍

Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to copy-edit this, but the content looks good, and I definitely think we should do these every couple of months. 👍

@Turbo87 Turbo87 force-pushed the crates-io-update branch from f3b3e43 to 87c96ff Compare July 25, 2024 11:59
@Turbo87 Turbo87 requested a review from jtgeibel July 25, 2024 11:59
@Turbo87
Copy link
Member Author

Turbo87 commented Jul 25, 2024

@jtgeibel looks like I need an approval from a team lead again 😉

@Turbo87
Copy link
Member Author

Turbo87 commented Jul 25, 2024

also, all review comments should be addressed now :)

@marcoieni
Copy link
Member

Minor complaint as a new-joiner: I would have loved to review the changes, but the force-push makes it hard 😵

@Turbo87
Copy link
Member Author

Turbo87 commented Jul 26, 2024

fair, sorry about that 🫣

@Turbo87 Turbo87 force-pushed the crates-io-update branch from 87c96ff to 5c6882a Compare July 26, 2024 07:30
@Turbo87
Copy link
Member Author

Turbo87 commented Jul 26, 2024

I've git refloged it and restored the intermediate commits :)

@marcoieni
Copy link
Member

marcoieni commented Jul 26, 2024

oh, wow I didn't know you could do that!
Thanks, all the changes look amazing ⭐

Co-authored-by: Marco Ieni <11428655+MarcoIeni@users.noreply.github.com>
@Turbo87
Copy link
Member Author

Turbo87 commented Jul 29, 2024

@rust-lang/leads I already have three team member approvals. Could one of you approve to so that we can ship this? 🙏

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date is a bit stale (26 July), let me know if you want to change it and I can re-approve.

@Turbo87 Turbo87 merged commit bd8e10c into rust-lang:master Jul 29, 2024
3 checks passed
@Turbo87
Copy link
Member Author

Turbo87 commented Jul 29, 2024

thanks everyone! it's live now: https://blog.rust-lang.org/2024/07/29/crates-io-development-update.html :)

@Turbo87 Turbo87 deleted the crates-io-update branch July 29, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content An issue related to an article.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants