Skip to content

Fix frontmatter assumption #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix frontmatter assumption #1158

merged 1 commit into from
Oct 24, 2023

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 24, 2023

Using ---\n assumes that all files use \n line endings, but one of our latest blog posts is using \r\n instead. This commit reverts the assumption about the frontmatter again to fix the rendering of that blog post.

This fixes a hidden merge conflict between #1145 and #1132.

Using `---\n` assumes that all files use `\n` line endings, but one of our latest blog posts is using `\r\n` instead. This commit reverts the assumption about the frontmatter again to fix the rendering of that blog post.
Copy link
Member

@jdno jdno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @Turbo87 offline. Fine to revert the assumption for now, but we should fix this properly to avoid similar issues in the future.

@Turbo87 Turbo87 merged commit 357ed1b into rust-lang:master Oct 24, 2023
@Turbo87 Turbo87 deleted the fix-build branch October 24, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants