Skip to content

Add Inside Rust post announcing async_fn_in_trait on nightly #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 17, 2022

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Nov 1, 2022

cc @rust-lang/wg-async

@tmandry tmandry changed the title Add post announcing async_fn_in_trait on nightly Add Inside Rust post announcing async_fn_in_trait on nightly Nov 2, 2022
@tmandry
Copy link
Member Author

tmandry commented Nov 2, 2022

Thanks for the feedback. Let's hold off until I'm back from vacation next week to post this, so I can be around to help answer questions.

@tmandry
Copy link
Member Author

tmandry commented Nov 17, 2022

I revised the wording quite a bit and I think this is now ready to land. Please let me know soon if you think more revisions are needed!

Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, thanks for the changes! I've left a few more comments inline, but I hope they're all minor to accommodate (and none of them are blocking concerns)

@Manishearth Manishearth merged commit da36bb6 into rust-lang:master Nov 17, 2022
@tmandry tmandry deleted the patch-1 branch November 17, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants