Set the experimental document attribute to enable the keyboard macro
#191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noritada
added a commit
to noritada/rust-analyzer
that referenced
this pull request
Dec 14, 2022
…d draft changelog The keyboard macro (`kbd:[...]`) requires this attribute. This default change will prevent issues like rust-analyzer/rust-analyzer.github.io#191 .
|
Ref. https://docs.asciidoctor.org/asciidoc/latest/macros/keyboard-macro/ I thought this might not be needed in a more recent version of AsciiDoc, but that doesn't seem to be the case. Thanks! |
lnicola
approved these changes
Dec 14, 2022
|
Confirmed to work:
|
bors
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Dec 14, 2022
…log-draft, r=lnicola minor: Set the `experimental` AsciiDoc document attribute to generated draft changelog This PR sets the `experimental` AsciiDoc document attribute to generated draft changelog. That attribute is required by the keyboard macro (`kbd:[...]`). This change of the draft will prevent issues like rust-analyzer/rust-analyzer.github.io#191 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that HTML outputs of some changelog posts such as Changelog #11 contains raw keyboard macro expressions such as
kbd:[Enter].This PR sets the
experimentaldocument attribute on those posts to make the macro processed.I think it would be nice if the changelog draft has that attribute by default, so I will post a separate PR to change the draft generated by
xtask release.