Skip to content

Add Kakoune and Helix configuration #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

woshilapin
Copy link

Fixes #180.

I choose to put links to existing official documentation instead of copy/paste what to do with the risk of being out-of-date (especially for these young editors where things move often).

@lnicola
Copy link
Member

lnicola commented Feb 23, 2022

Please add hard line breaks after each sentence, it makes reading diffs much easier.

And I'm not sure about the helix remark/emoji. I don't mind them that much, but they don't really fit the style used in the rest of the docs.

@woshilapin
Copy link
Author

Please add hard line breaks after each sentence, it makes reading diffs much easier.

Indeed, done.

And I'm not sure about the helix remark/emoji. I don't mind them that much, but they don't really fit the style used in the rest of the docs.

I might have been a bit too comfortable here 😅 Let's say it was late yesterday evening! I removed it.

manual.adoc Outdated
@@ -427,6 +427,40 @@ Then click on apply, and restart the LSP server for your rust project.

https://gitlab.com/cppit/jucipp[juCi++] has built-in support for the language server protocol, and since version 1.7.0 offers installation of both Rust and rust-analyzer when opening a Rust file.

=== Kakoune

https://kakoune.org/[Kakoune] editor support LSP with the help of https://github.com/kak-lsp/kak-lsp[`kak-lsp`].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://kakoune.org/[Kakoune] editor support LSP with the help of https://github.com/kak-lsp/kak-lsp[`kak-lsp`].
https://kakoune.org/[Kakoune] supports LSP with the help of https://github.com/kak-lsp/kak-lsp[`kak-lsp`].

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in ebca994.

manual.adoc Outdated

=== Helix

https://docs.helix-editor.com/[Helix] editor does support LSP by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
https://docs.helix-editor.com/[Helix] editor does support LSP by default.
https://docs.helix-editor.com/[Helix] supports LSP by default.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in ebca994.

@lnicola
Copy link
Member

lnicola commented Feb 23, 2022

bors d+

changelog fix (first contribution) add install instructions for Kakoune and Helix.

@bors
Copy link
Contributor

bors bot commented Feb 23, 2022

✌️ woshilapin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@woshilapin
Copy link
Author

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 23, 2022

Configuration problem:
bors.toml: not found

@woshilapin
Copy link
Author

First time I interact with bors. I thought I was allowed to do bors r+ after @lnicola did bors d+, but seems like there is a problem. Did I do something wrong?

@lnicola
Copy link
Member

lnicola commented Feb 23, 2022

Sorry I didn't notice it, can you port your changes to https://github.com/rust-analyzer/rust-analyzer/blob/master/docs/user/manual.adoc?

There is a comment at the top:

IMPORTANT: the master copy of this document lives in the https://github.com/rust-analyzer/rust-analyzer repository

@woshilapin
Copy link
Author

New PR opened in rust-lang/rust-analyzer#11535.

bors bot added a commit to rust-lang/rust-analyzer that referenced this pull request Feb 23, 2022
11535: Add Kakoune and Helix configuration r=lnicola a=woshilapin

Follow-up of rust-analyzer/rust-analyzer.github.io#181
Fixes rust-analyzer/rust-analyzer.github.io#180

cc `@lnicola` 

Co-authored-by: Jean SIMARD <woshilapin@tuziwo.info>
lnicola added a commit that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add some more IDE configurations in the user manual
2 participants