Changelog #109 #173
Merged
Changelog #109 #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Dec 27, 2021
|
|
||
| There are some recent known issues related to the VS Code extension and the update mechanism: | ||
|
|
||
| * Since last week, the stable extension contains the server binary, avoiding the need to download it on the first load. Unfortunately, Open VSX, which is the marketplace used by VSCodium and other free Code builds https://github.com/rust-analyzer/rust-analyzer/issues/11080[does not] support this feature, sometimes serving users binaries for the wrong platform. The workaround is to install the non-free version of Code, or to manually download the VSIX for your platform from GitHub releases. |
There was a problem hiding this comment.
Let’s maybe flip the order of work-arounds?
matklad
reviewed
Dec 27, 2021
|
|
||
| There are some recent known issues related to the VS Code extension and the update mechanism: | ||
|
|
||
| * Since last week, the stable extension contains the server binary, avoiding the need to download it on the first load. Unfortunately, Open VSX, which is the marketplace used by VSCodium and other free Code builds https://github.com/rust-analyzer/rust-analyzer/issues/11080[does not] support this feature, sometimes serving users binaries for the wrong platform. The workaround is to install the non-free version of Code, or to manually download the VSIX for your platform from GitHub releases. |
There was a problem hiding this comment.
It might be useful to rephrase this a bit: “if you use X, than do Y. This is caused by Z”. That is, emphasize “am I affected” and “what should I do”, rather than the underlying issue.
matklad
approved these changes
Dec 27, 2021
lnicola
force-pushed
the
changelog-109
branch
from
3fce0c2 to
a54f4c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @matklad if you're around
The release isn't out yet because GitHub Actions is having a really bad day.