Declare erb as a dependency #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
approved these changes
May 12, 2025
tagliala
added a commit
to activeadmin/activeadmin
that referenced
this pull request
May 21, 2025
Additionally: - Relax eslint dependency constraint since eslint/eslint#19682 has been addressed - Explicitly require `erb` 4 for Rails 7.1 and 7.2 because of ruby/rdoc#1368
tagliala
added a commit
to activeadmin/activeadmin
that referenced
this pull request
May 21, 2025
Additionally: - Relax eslint dependency constraint since eslint/eslint#19682 has been addressed - Explicitly require `erb` 4 for Rails 7.1 and 7.2 because of ruby/rdoc#1368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
erbis still a default gem, it's better to declare it as a dependency to make sure its dependencies (e.g.cgi) gets properly resolved too.