Skip to content

Extend consumer to support SASL/OAuth #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

marcelmarcelD
Copy link

  • Implemented procedure for getting refresh token
  • Implemented procedure for getting access token
  • Implemented OAuth2 callback
  • Updated requirements.txt file (update version for confluent-kafka library)
  • Update version to 1.6.1

@robooo
Copy link
Owner

robooo commented Jun 8, 2021

Thanks for PR!

I will need first release missing version and after updating to the latest we can look at this one.

Till that time, I would like to leave this as a wrapper without any more functionality, so the token provider + requests_oauthlib and going through the full workflow of oauth is not necessary in this library (+ you can see you hardcoded the parsing of antiforgery but what if someone else doesn't use it or use other naming etc... then it couldn't be re-used and rewriting the TokenProvider would be needed again).
But this could be used as a good example of usage (you can refactor it to examples like test_oauth.robot)

Otherwise the extension of consumer is needed (+ don't forget to extend producer with oauth params too).

@marcelmarcelD
Copy link
Author

Hi , thanks for your inputs.

@robooo
Copy link
Owner

robooo commented Oct 27, 2021

Hi again @marcelmarcelD, so I had a closer look to this implementation and as I said before it will needs more generous approach how to handle the workflow. This is nice example of anti-forgery, cookies, renewal etc. but it would not fit everyone and this library doesn't need to do this stuff (at least I think that). But if you will have some ideas how to make this functionality more generous and optional please don't hesitate and contact me or send PR's!

If you are interested in updating test environment and implementing example how to use oauth please see #21

@robooo robooo closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants