-
-
Notifications
You must be signed in to change notification settings - Fork 32
Python3.11 compatibility #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pass | ||
|
||
class Response: | ||
class ResponseType: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
COMPILE_ERROR = 17 | ||
RUNTIME_ERROR = 18 | ||
|
||
class ErrorType: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar blocks of code found in 2 locations. Consider refactoring.
Code Climate has analyzed commit 041dc5d and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
… literal. Did you mean "!="?
Apologize for closing/opening. Confirming my verison is working in my 3.11 appliction. Happy to help cherry pick these changes into mainline, but definitely think updates are necessary for continued python support. Love this project, show must go on! |
Closing as it has been integrated from another PR #298 @stephanelsmith thanks for the support! |
Reason for the change
Python3.11 compatibility issues with running
Description
"@asyncio.coroutine" and "yield from" syntax no longer allowed in 3.11. Changed to "async" and "await" respectively.
Code examples
For example, changes made like this:
Checklist
References
I have a number of compatibility updates, made some for 3.10 as well last year. I wanted decreased verbosity in the export.
Happy to cherry pick what makes sense, but would like to see continued support track with Python versions.