Skip to content

fix failing dump command #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022
Merged

fix failing dump command #276

merged 1 commit into from
May 12, 2022

Conversation

besworks
Copy link
Contributor

Reason for the change

Per Issue #225

File ".../rethinkdb/utils_common.py", line 311, in take_action
values[dest] = getpass.getpass("Password for admin: ")
TypeError: 'Values' object does not support item assignment

Description
The values object is an instance of optparse_parser.Values which, as the error message states, does not support item assignment. I modified the option checker to use the ensure_value method of the values object to set the password.

Checklist

@gabor-boros gabor-boros linked an issue May 11, 2022 that may be closed by this pull request
@gabor-boros
Copy link
Member

gabor-boros commented May 11, 2022

@besworks Thank you for the fix 🎉

This looks good to me! I'll merge this later today and cut a new release on Pypi.

@gabor-boros
Copy link
Member

gabor-boros commented May 11, 2022

Although I could do the release now, I prefer doing it with fresh eyes. So I'll do it tomorrow morning as a first step after my coffee.

Sorry about any inconviniences.

@gabor-boros gabor-boros merged commit bc1a75a into rethinkdb:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dump failed with v2.4.7
2 participants