Skip to content

up to python 3.10 #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rethinkdb/ast.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def expr(val, nesting_depth=20):

if isinstance(val, RqlQuery):
return val
elif isinstance(val, collections.Callable):
elif isinstance(val, collections.abc.Callable):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change also needed for collections.Mapping

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed with #253.

return Func(val)
elif isinstance(val, (datetime.datetime, datetime.date)):
if not hasattr(val, "tzinfo") or not val.tzinfo:
Expand Down
2 changes: 1 addition & 1 deletion rethinkdb/asyncio_net/net_asyncio.py
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ def connect(self, timeout):
self._streamreader, self._streamwriter = yield from asyncio.open_connection(
self._parent.host,
self._parent.port,
loop=self._io_loop,
#loop=self._io_loop, droped at py3.10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the driver backward incompatible with older python versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does? How so? The parameter was optional and otherwise it uses the active loop.

ssl=ssl_context,
)
self._streamwriter.get_extra_info("socket").setsockopt(
Expand Down