-
-
Notifications
You must be signed in to change notification settings - Fork 32
up to python 3.10 #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
up to python 3.10 #269
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -202,7 +202,7 @@ def connect(self, timeout): | |
self._streamreader, self._streamwriter = yield from asyncio.open_connection( | ||
self._parent.host, | ||
self._parent.port, | ||
loop=self._io_loop, | ||
#loop=self._io_loop, droped at py3.10 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This makes the driver backward incompatible with older python versions. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It does? How so? The parameter was optional and otherwise it uses the active loop. |
||
ssl=ssl_context, | ||
) | ||
self._streamwriter.get_extra_info("socket").setsockopt( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change also needed for collections.Mapping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was fixed with #253.