Skip to content

Implement DB URL connection support #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 2, 2020
Merged

Conversation

gabor-boros
Copy link
Member

@gabor-boros gabor-boros commented Feb 17, 2020

Reason for the change
This PR is related to rethinkdb/rethinkdb#4101.

Description
Add DB connection URL support.

Code examples

>>> from rethinkdb import r
>>> url = "rethinkdb://admin@127.0.0.1:28015/test?timeout=30"
>>> conn = r.connect(url=url)
>>> r.table_create('marvel').run(conn)
{'config_changes': [{'new_val': {'db': 'test', 'durability': 'hard', 'id': '57d565e9-55ca-42f8-85e6-792068ad4a52', 'indexes': [], 'name': 'mar
vel', 'primary_key': 'id', 'shards': [{'nonvoting_replicas': [], 'primary_replica': 'gabor_local_umw', 'replicas': ['gabor_local_umw']}], 'wri
te_acks': 'majority', 'write_hook': None}, 'old_val': None}], 'tables_created': 1}

Checklist

  • Unit tests created/modified
  • Integration tests created/modified

References

@gabor-boros gabor-boros added the enhancement New feature or request label Feb 17, 2020
@gabor-boros gabor-boros self-assigned this Feb 17, 2020
@gabor-boros
Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Coverage increased per file
===========================
+ rethinkdb/net.py  1
         

See the complete overview on Codacy

@gabor-boros gabor-boros merged commit 46ce52b into master Mar 2, 2020
@gabor-boros gabor-boros deleted the support-db-url-schemas branch March 2, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant