Skip to content

Add syntax highlighting support for int polyvars #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2021

Conversation

amiralies
Copy link
Collaborator

No description provided.

@amiralies amiralies requested a review from ryyppy May 9, 2021 07:29
@ryyppy
Copy link
Member

ryyppy commented May 14, 2021

sorry for the delay, I guess we can safely assume that this will just work as advertised? How does the new syntax look like in a screenshot?

@amiralies
Copy link
Collaborator Author

Looks similar to other polyvar syntaxes.
image

Should we update this based on this commit rescript-lang/syntax@dc53370 to disallow higlighting of #10abc?

@ryyppy
Copy link
Member

ryyppy commented May 14, 2021

Should we update this based on this commit rescript-lang/syntax@dc53370 to disallow higlighting of #10abc?

Yeah that would be neat.

Can you also create a new file in the basic example folder called polySyntax.res and add some different polyvar assignments?

This might be useful to later on look through all the different syntax highlighting features.

(Definitely need to get rid of the bar.res, baz.res wording at some point..)

@ryyppy
Copy link
Member

ryyppy commented May 14, 2021

looking good now! feel free to merge when this is ready 👍

@amiralies amiralies merged commit f614187 into master May 14, 2021
@ryyppy ryyppy deleted the int-polyvar-syntax branch May 14, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants