This repository was archived by the owner on Jun 15, 2023. It is now read-only.
add API for parsing impl/interface from a raw string #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Sep 19, 2022
|
The failing Windows test seem to be about a cygwin mirror that times out. Merging anyway since that's expected to resolve itself soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an API for parsing impl/interface from a raw string. Main use case right now is in rescript-lang/rescript-vscode#547 where I need to parse a raw string and don't want to have to put the contents into a temp file just to parse it.
Tried adding it to
parseEnginefirst but that required me to add implementations for re/ml, which felt unecessary.