This repository was archived by the owner on Jun 15, 2023. It is now read-only.
put parseTagName at toplevel #545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
commented
Jun 14, 2022
| @@ -361,6 +364,7 @@ let isListTerminator grammar token = | |||
| | PackageConstraint, token when token <> And -> true | |||
| | ConstructorDeclaration, token when token <> Bar -> true | |||
| | AttributePayload, Rparen -> true | |||
| | TagNames, Rbracket -> true | |||
There was a problem hiding this comment.
This actually needs to be specified in order for parseRegion to work.
cristianoc
commented
Jun 14, 2022
| @@ -336,6 +338,7 @@ let isListElement grammar token = | |||
| | JsxAttribute -> isJsxAttributeStart token | |||
| | JsFfiImport -> isJsFfiImportStart token | |||
| | AttributePayload -> token = Lparen | |||
| | TagNames -> token = Hash | |||
There was a problem hiding this comment.
This is not currently used, as when returning None the current token won't be Hash, but it's good to have it here for later in case the parse tag function changes and does some more refined error recovery after #.
cristianoc
commented
Jun 14, 2022
| @@ -4995,6 +4983,20 @@ and parsePolymorphicVariantType ~attrs p = | |||
| Parser.expect Rbracket p; | |||
| variant | |||
|
|
|||
| and parseTagName p = | |||
There was a problem hiding this comment.
These need to be at toplevel for the analysis to find them.
The restriction seems OK for this use case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #540