Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

Do not parse past Eof #542

Merged
merged 3 commits into from
Jun 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/res_core.ml
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ let isEs6ArrowExpression ~inTernary p =
* *)
false
| _ ->
Parser.next state;
Parser.nextUnsafe state;
(* error recovery, peek at the next token,
* (elements, providerId] => {
* in the example above, we have an unbalanced ] here
Expand Down Expand Up @@ -623,7 +623,7 @@ let rec parseLident p =
None
) else (
let rec loop p =
if not (Recover.shouldAbortListParse p)
if not (Recover.shouldAbortListParse p) && p.token <> Eof
then begin
Parser.next p;
loop p
Expand Down
6 changes: 5 additions & 1 deletion src/res_parser.ml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ let endRegion p =
* in the parser's state. Every comment contains the end position of its
* previous token to facilite comment interleaving *)
let rec next ?prevEndPos p =
if p.token = Eof then assert false;
let prevEndPos = match prevEndPos with Some pos -> pos | None -> p.endPos in
let (startPos, endPos, token) = Scanner.scan p.scanner in
match token with
Expand All @@ -65,6 +66,9 @@ let rec next ?prevEndPos p =
p.startPos <- startPos;
p.endPos <- endPos

let nextUnsafe p =
if p.token <> Eof then next p

let nextTemplateLiteralToken p =
let (startPos, endPos, token) = Scanner.scanTemplateLiteralToken p.scanner in
p.token <- token;
Expand All @@ -82,7 +86,7 @@ let make ?(mode=ParseForTypeChecker) src filename =
let parserState = {
mode;
scanner;
token = Token.Eof;
token = Token.Semicolon;
startPos = Lexing.dummy_pos;
prevEndPos = Lexing.dummy_pos;
endPos = Lexing.dummy_pos;
Expand Down
1 change: 1 addition & 0 deletions src/res_parser.mli
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ val make: ?mode:mode -> string -> string -> t
val expect: ?grammar:Grammar.t -> Token.t -> t -> unit
val optional: t -> Token.t -> bool
val next: ?prevEndPos:Lexing.position -> t -> unit
val nextUnsafe: t -> unit (* Does not assert on Eof, makes no progress *)
val nextTemplateLiteralToken: t -> unit
val lookahead: t -> (t -> 'a) -> 'a
val err:
Expand Down
1 change: 1 addition & 0 deletions tests/parsing/infiniteLoops/expected/templateEof.res.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fatal error: exception File "src/res_parser.ml", line 52, characters 23-29: Assertion failed
3 changes: 3 additions & 0 deletions tests/parsing/infiniteLoops/templateEof.res
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
et foo = x =>
switch x {
| `${