Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

441: fix missing comments in switch #510

Merged
merged 1 commit into from
May 30, 2022
Merged

441: fix missing comments in switch #510

merged 1 commit into from
May 30, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 29, 2022

No description provided.

@cristianoc cristianoc requested a review from IwanKaramazow May 30, 2022 03:37
IwanKaramazow
IwanKaramazow approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@IwanKaramazow IwanKaramazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is good for now.

When we'll support comments around/in braced expressions, we'll probably have to tweak this again to take the location of the braces in mind.

@IwanKaramazow IwanKaramazow merged commit 032bf40 into rescript-lang:master May 30, 2022
@cknitt cknitt deleted the 441 branch May 30, 2022 05:45
@cknitt cknitt mentioned this pull request Jun 17, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IwanKaramazow IwanKaramazow IwanKaramazow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @IwanKaramazow