Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

Printable attribute improvements #504

Merged
merged 2 commits into from
May 27, 2022
Merged

Printable attribute improvements #504

merged 2 commits into from
May 27, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 27, 2022

  • Spelling fix: printeable -> printable
  • Avoid unnecessary List construction
  • Make sure filterPrintableAttributes and partitionPrintableAttributes use the same definition of "printable"

IwanKaramazow
IwanKaramazow approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@IwanKaramazow IwanKaramazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this. This is great.

@IwanKaramazow IwanKaramazow merged commit 0957217 into rescript-lang:master May 27, 2022
@cknitt cknitt deleted the printable-attribute-improvements branch May 27, 2022 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IwanKaramazow IwanKaramazow IwanKaramazow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @IwanKaramazow