Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

Fix parsing punned record fields with module name #479

Merged
merged 5 commits into from
Mar 24, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Mar 22, 2022

This fixes rescript-lang/rescript#5362.

I.e.

{A.a, b}

is now correctly parsed to match the AST for

{A.a: a, b: b}

and not for

{A.a: A.a, b: b}

@cknitt cknitt changed the title Fix parsing punned record fields with module name ({A.a, b}) Fix parsing punned record fields with module name Mar 22, 2022
@cknitt cknitt requested a review from IwanKaramazow March 23, 2022 20:00
Copy link
Contributor

@IwanKaramazow IwanKaramazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @cknitt

@IwanKaramazow IwanKaramazow merged commit 546cb85 into rescript-lang:master Mar 24, 2022
@cknitt cknitt deleted the fix-punned-fields branch March 24, 2022 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{A.a, b} is reformatted incorrectly
3 participants