This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Give good error when a type declaration has an inline record type when not permitted #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IwanKaramazow
force-pushed
the
IllegalInlineRecord
branch
from
1897a72 to
a79adc3
Compare
|
Hey - is it better to say something like: "Nested record types must be defined separately"? And perhaps give a simple example? This would also cover the case when not using inline records |
|
Nested isn't as accurate as inline. And when we talk about defined separately we'd have to exclude variant constructors, which comes back to this |
|
Actually, good examples is nice. Maybe file it here? I should also move that repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97