Doc string for React component

[mununki]

I got a report that the doc string for the react component is not showing on the application site.

module C = {
  /** type make: unit => React.element */
  @react.component
  let make = () => React.null
}

module C1 = {
  @react.component
  /** type make: unit => React.element */
  let make = () => React.null
}

module C2 = {
  /** type make: unit => React.element */
  @react.component @module("foo")
  external make: unit => React.element = "comp"
}

module C3 = {
  @react.component @module("foo")
  /** type make: unit => React.element */
  external make: unit => React.element = "comp"
}

<C /> // hover on `C`

In the vscode, it shows only type information.

compiler: v10.1.0.rc-3
rescript-react: v0.11.0.rc-3

[mununki]

I'm going to check the loc that JSX v4 handles

[cristianoc]

Looks like all doc comments on unrelated values in the same module also disappear. So probably an issue of processing the inner module.

Btw this compiles without errors:

module C2 = {
  @react.component
  external make: thisTypeDoesNotExist => React.element = "comp"
}

For what it's worth, it was the same in V3, so there's no change there. I guess the type is just ignore unless some named args are given.

[cristianoc]

Simple repro: nothing to do with react components.

module CC = {
  /** First Comment */
  let a = 10

  /** Second Comment */
  let a = a
}

let q = CC.a

[cristianoc]

Closing this.

[cristianoc]

Fixed the extension here: rescript-lang/rescript-vscode#621