Skip to content

Replace "raise" in tests with "throw"; treat "throw" like "raise" in analysis #7521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 26, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 25, 2025

No description provided.

@cknitt cknitt requested a review from cristianoc May 25, 2025 08:28
Copy link

pkg-pr-new bot commented May 25, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7521

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7521

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7521

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7521

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7521

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7521

commit: 119ca88

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I was wondering about whether formatting raise to throw would be useful, but then there's the risk that a function with that name gets redefined user-side, and formatting would break it.

@cknitt cknitt merged commit c8e2639 into rescript-lang:master May 26, 2025
16 checks passed
@cknitt cknitt deleted the throw-in-examples branch May 26, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants