Skip to content

Add optional ~options argument to Console.dir #7504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025

Conversation

mediremi
Copy link
Contributor

console.dir supports an optional options argument, with options.depth being particularly useful for logging nested data structures.

@mediremi mediremi marked this pull request as ready for review May 22, 2025 18:34
@mediremi mediremi changed the title Add optional ~options argument to Console.dir Add optional ~options argument to Console.dir May 22, 2025
@zth zth self-requested a review May 22, 2025 19:07
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 😄

@zth
Copy link
Collaborator

zth commented May 22, 2025

@mediremi mind rebasing?

@mediremi
Copy link
Contributor Author

I'll do it now 👍

@zth zth enabled auto-merge (squash) May 22, 2025 19:10
Copy link

pkg-pr-new bot commented May 22, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7504

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7504

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7504

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7504

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7504

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7504

commit: 8af25d6

@zth zth merged commit 6f799bc into rescript-lang:master May 22, 2025
16 checks passed
@mediremi mediremi deleted the console-dir branch May 24, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants