Skip to content

Allow oneliner when including module with single type alias #7502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented May 22, 2025

This is a slightly selfish ask, but when including multiple modules, it can get rather verbose if these take three lines.

The unit test illustrates the problem best.

@nojaf nojaf requested a review from shulhi May 22, 2025 12:22
@fhammerschmidt
Copy link
Member

Not selfish, I like it too!
That bothered me for some time now as well.

@zth
Copy link
Collaborator

zth commented May 22, 2025

@nojaf try and rebase to master, there was some test output missing.

@nojaf
Copy link
Collaborator Author

nojaf commented May 22, 2025

@zth was already on top of it, but did not ran make lib

Copy link

pkg-pr-new bot commented May 22, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7502

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7502

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7502

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7502

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7502

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7502

commit: 108ae24

@nojaf nojaf merged commit e2e1e3c into rescript-lang:master May 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants