Store the label loc directly in the label, for application for now. #7253
Conversation
cristianoc
force-pushed
the
loc-directly-in-label
branch
2 times, most recently
from
61152e3 to
26f4de9
Compare
cristianoc
force-pushed
the
loc-directly-in-label
branch
from
26f4de9 to
e236e21
Compare
Preserve `isMobile={isMobile}` when it's like that in the source, instead of reformatting to `isMobile`.
Do we want that?
| @@ -51,7 +51,7 @@ let x = | |||
| let x = <div className="container" className2="container2" className3="container3" onClick /> | |||
|
|
|||
| let nav = | |||
| <Nav isMobile fullScreen={!isMobile ? false : isOpen}> | |||
| <Nav isMobile={isMobile} fullScreen={!isMobile ? false : isOpen}> | |||
There was a problem hiding this comment.
Restored this behaviour where isMobile={isMobile} in the source is not reformatted to the punned isMobile.
Is this intended?
There was a problem hiding this comment.
IIRC we don't autopun in JSX, yes.
There was a problem hiding this comment.
It's not punned because of the brackets.
This would be punned
<Nav isMobile=isMobile fullScreen={!isMobile ? false : isOpen}>
formats to
<Nav isMobile fullScreen={!isMobile ? false : isOpen}>
There was a problem hiding this comment.
Right, that's it yeah. I think that's good behavior.
| | Lbl of string loc (* label:T -> ... *) | ||
| | Opt of string loc (* ?label:T -> ... *) |
There was a problem hiding this comment.
Very small nit, but these should probably be in ReScript syntax, no?
| @@ -51,7 +51,7 @@ let x = | |||
| let x = <div className="container" className2="container2" className3="container3" onClick /> | |||
|
|
|||
| let nav = | |||
| <Nav isMobile fullScreen={!isMobile ? false : isOpen}> | |||
| <Nav isMobile={isMobile} fullScreen={!isMobile ? false : isOpen}> | |||
There was a problem hiding this comment.
IIRC we don't autopun in JSX, yes.
|
Now all the location information is stored in the labels directly. Merging this into #7247 to get a consolidated view of the changes. |
Create type
arg_label_localongsidearg_labelto store location in the label.This is only used by application for the moment.