Optimize compilation of switch statements for untagged variants #7135
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // Generated by ReScript, PLEASE EDIT WITH CARE | ||
|
|
||
| import * as $$Array from "rescript/lib/es6/Array.js"; | ||
|
|
||
| function decodeUser(json) { | ||
| if (!(typeof json === "object" && !Array.isArray(json))) { | ||
| return; | ||
| } | ||
| let id = json.id; | ||
| if (typeof id !== "string") { | ||
| return; | ||
| } | ||
| let name = json.name; | ||
| if (typeof name !== "string") { | ||
| return; | ||
| } | ||
| let age = json.age; | ||
| if (typeof age !== "number") { | ||
| return; | ||
| } | ||
| let email = json.email; | ||
| let tmp; | ||
| tmp = typeof email === "string" ? email : undefined; | ||
| return { | ||
| id: id, | ||
| name: name, | ||
| age: age | 0, | ||
| email: tmp | ||
| }; | ||
| } | ||
|
|
||
| function decodeGroup(json) { | ||
| if (!(typeof json === "object" && !Array.isArray(json))) { | ||
| return; | ||
| } | ||
| let id = json.id; | ||
| if (typeof id !== "string") { | ||
| return; | ||
| } | ||
| let name = json.name; | ||
| if (typeof name !== "string") { | ||
| return; | ||
| } | ||
| let users = json.users; | ||
| if (Array.isArray(users)) { | ||
| return { | ||
| id: id, | ||
| name: name, | ||
| users: $$Array.filterMap(users, decodeUser) | ||
| }; | ||
| } | ||
|
|
||
| } | ||
|
|
||
| export { | ||
| decodeUser, | ||
| decodeGroup, | ||
| } | ||
| /* No side effect */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| type user = { | ||
| id: string, | ||
| name: string, | ||
| age: int, | ||
| email: option<string>, | ||
| } | ||
|
|
||
| type group = { | ||
| id: string, | ||
| name: string, | ||
| users: array<user>, | ||
| } | ||
|
|
||
| let decodeUser = json => { | ||
| switch json { | ||
| | JSON.Object(dict{ | ||
| "id": JSON.String(id), | ||
| "name": String(name), | ||
| "age": Number(age), | ||
| "email": ?email, | ||
| }) => | ||
| Some({ | ||
| id, | ||
| name, | ||
| age: age->Float.toInt, | ||
| email: switch email { | ||
| | Some(String(email)) => Some(email) | ||
| | _ => None | ||
| }, | ||
| }) | ||
| | _ => None | ||
| } | ||
| } | ||
|
|
||
| let decodeGroup = json => { | ||
| switch json { | ||
| | JSON.Object(dict{"id": JSON.String(id), "name": String(name), "users": Array(users)}) => | ||
| Some({ | ||
| id, | ||
| name, | ||
| users: users->Array.filterMap(decodeUser), | ||
| }) | ||
| | _ => None | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theoretically this could be simplified to == null || type of "boolean", but I'm not sure it's that important tbh.