Skip to content

Remove Js.Vector and Js.List #6900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Remove Js.Vector and Js.List #6900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7703a43
Remove `Js.Vector` and `Js.List`
cometkim Jul 21, 2024
a1d9e61
changelog
cometkim Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
- Remove support for compiling `.ml` files, and general cleanup. https://github.com/rescript-lang/rescript-compiler/pull/6852
- Remove `rescript convert` subcommand. https://github.com/rescript-lang/rescript-compiler/pull/6860
- Remove support for `@bs.send.pipe`. This also removes all functions in `Js_typed_array` that rely on `@bs.send.pipe`. https://github.com/rescript-lang/rescript-compiler/pull/6858 https://github.com/rescript-lang/rescript-compiler/pull/6891
- Remove deprecated `Js.Vector` and `Js.List`. https://github.com/rescript-lang/rescript-compiler/pull/6900

#### :bug: Bug Fix

Expand Down
2 changes: 0 additions & 2 deletions jscomp/core/outcome_printer_ns.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ let out_ident ppf s =
| "Js_int" -> "Js.Int"
| "Js_option" -> "Js.Option"
| "Js_result" -> "Js.Result"
| "Js_list" -> "Js.List"
| "Js_vector" -> "Js.Vector"
(* Belt_libs *)
| "Belt_Id" -> "Belt.Id"
| "Belt_Array" -> "Belt.Array"
Expand Down
6 changes: 0 additions & 6 deletions jscomp/others/js.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,12 +260,6 @@ module Option = Js_option
/** Define the interface for result */
module Result = Js_result

/** Provide utilities for list */
module List = Js_list

/** Provides bindings for JS Vector */
module Vector = Js_vector

/** Provides bindings for console */
module Console = Js_console

Expand Down
213 changes: 0 additions & 213 deletions jscomp/others/js_list.res
View file
Open in desktop

This file was deleted.

71 changes: 0 additions & 71 deletions jscomp/others/js_list.resi
View file
Open in desktop

This file was deleted.

Loading