-
Notifications
You must be signed in to change notification settings - Fork 469
Organize package.json
content
#6849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c718e60
to
0231e0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you add the other maintainers too to this list, eg everyone showing up in the drop down when ask ing for a review.
I cannot ask for a review myself as I don't have access to do that. Can you share the actual maintainer list? Or we can add a |
Let me abuse the system and as for a bunch of reviews to this PR... |
OK see list of reviewers to this PR. |
Lol thanks |
Since there are many, I can format it as shortened like "Name (homepage)". Btw, the value of the It seems like some of you don't prefer exposing email (or name) on it. That's totally fine, but I wanna make sure everyone here is ok. Actually I can scrape npm user info and check your email via To avoid these potential problems, I suggest unifying the format as "Name (GitHub address)". Except for Bob's profile, which originally existed. |
0231e0c
to
7640c8c
Compare
I'm a bit torn here. @cristianoc @zth what do you think? |
Alphabetical sounds great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Putting Gabriel and Cristiano first would indeed make sense too, as you guys want!
It seems we're missing Comet Kim from the list. |
Right! @cometkim would you add yourself, too? 🙂 |
Haha thanks. But not this moment 😅 |
Oh well, I've been invited |
Btw, do we prefer |
Co-approved 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging now. Any objections by those who have not answered yet can be addressed in separate PRs. 🙂 |
Hoisted up the package's basic information. Arranged them in a meaningful order.
And changed the current maintainer information to @cristianoc 's one