Skip to content

Organize package.json content #6849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

cometkim
Copy link
Member

@cometkim cometkim commented Jul 3, 2024

Hoisted up the package's basic information. Arranged them in a meaningful order.

And changed the current maintainer information to @cristianoc 's one

@cometkim cometkim marked this pull request as draft July 3, 2024 20:48
@cometkim cometkim force-pushed the organize-manifest branch from c718e60 to 0231e0c Compare July 4, 2024 15:38
@cknitt cknitt requested a review from cristianoc July 6, 2024 05:22
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add the other maintainers too to this list, eg everyone showing up in the drop down when ask ing for a review.

@cometkim
Copy link
Member Author

cometkim commented Jul 9, 2024

eg everyone showing up in the drop down when ask ing for a review.

I cannot ask for a review myself as I don't have access to do that. Can you share the actual maintainer list?

Or we can add a CODEOWNERS file

@cristianoc
Copy link
Collaborator

eg everyone showing up in the drop down when ask ing for a review.

I cannot ask for a review myself as I don't have access to do that. Can you share the actual maintainer list?

Or we can add a CODEOWNERS file

Let me abuse the system and as for a bunch of reviews to this PR...

@cristianoc
Copy link
Collaborator

eg everyone showing up in the drop down when ask ing for a review.

I cannot ask for a review myself as I don't have access to do that. Can you share the actual maintainer list?
Or we can add a CODEOWNERS file

Let me abuse the system and as for a bunch of reviews to this PR...

OK see list of reviewers to this PR.

@cometkim
Copy link
Member Author

cometkim commented Jul 9, 2024

Lol thanks

@cometkim
Copy link
Member Author

cometkim commented Jul 9, 2024

Since there are many, I can format it as shortened like "Name (homepage)". Btw, the value of the author/maintainers/contributors field is identified based on NPM user info.

It seems like some of you don't prefer exposing email (or name) on it. That's totally fine, but I wanna make sure everyone here is ok.

Actually I can scrape npm user info and check your email via npx npm-user-cli <npm-user-name>. So I can see some of your have different email settings between NPM and GitHub, etc. In those cases, This may appear as a different ID in the NPM. This can happened in shared domains like gmail.com

To avoid these potential problems, I suggest unifying the format as "Name (GitHub address)". Except for Bob's profile, which originally existed.

@cometkim cometkim force-pushed the organize-manifest branch from 0231e0c to 7640c8c Compare July 9, 2024 20:10
@cometkim cometkim marked this pull request as ready for review July 9, 2024 20:12
@cknitt
Copy link
Member

cknitt commented Jul 10, 2024

I'm a bit torn here.
On the one hand, I would put Cristiano and Gabriel first, but on the other hand sorting contributors alphabetically makes sense, too.

@cristianoc @zth what do you think?

@cristianoc
Copy link
Collaborator

I'm a bit torn here. On the one hand, I would put Cristiano and Gabriel first, but on the other hand sorting contributors alphabetically makes sense, too.

@cristianoc @zth what do you think?

Alphabetical sounds great.

Copy link
Member

@tsnobip tsnobip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Putting Gabriel and Cristiano first would indeed make sense too, as you guys want!

@mununki
Copy link
Member

mununki commented Jul 10, 2024

It seems we're missing Comet Kim from the list.

@cknitt
Copy link
Member

cknitt commented Jul 21, 2024

It seems we're missing Comet Kim from the list.

Right! @cometkim would you add yourself, too? 🙂

@cometkim
Copy link
Member Author

Haha thanks. But not this moment 😅

@cometkim
Copy link
Member Author

Oh well, I've been invited

@cometkim
Copy link
Member Author

Btw, do we prefer maintainers or contributors (which have same meaning in the NPM manifest)

@cometkim
Copy link
Member Author

Co-approved 😁

@cknitt
Copy link
Member

cknitt commented Jul 21, 2024

Btw, do we prefer maintainers or contributors (which have same meaning in the NPM manifest)

No opinion on that.
PR is good to go from my view.

@jfrolich @ryyppy @zth @mununki your approval is still missing - ok for you, too?

Copy link
Member

@mununki mununki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No opinion on that. PR is good to go from my view.

@jfrolich @ryyppy @zth @mununki your approval is still missing - ok for you, too?

It's my honor.

@cknitt
Copy link
Member

cknitt commented Jul 22, 2024

Merging now. Any objections by those who have not answered yet can be addressed in separate PRs. 🙂

@cknitt cknitt merged commit 75afa9c into rescript-lang:master Jul 22, 2024
19 checks passed
@cometkim cometkim deleted the organize-manifest branch July 22, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants