-
Notifications
You must be signed in to change notification settings - Fork 469
Switch to Biome #6838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Biome #6838
Conversation
That does look nice! Is there any downside to it (other than people being unfamiliar with it)? |
I don't think so. It can be compared to ESLint in terms of ecosystem, but not to Prettier. People who are already using the Prettier extension should switch to the Biome extension. |
Btw, do we need to enable the linter rules & import sorting feature too? |
Would certainly be nice to help us cleaning up / modernizing the JS files. But that can also be done later - fine with me to merge only the formatting part now. (Is it ready to merge - as the PR is still in draft?) |
The CI now only checks for changes, so I ran
sooo fast 👍 (errors were comments in JSON files) |
Ohh, the gentype test includes ESLint. We can replace it with Biome check. Wait for it... |
Done! |
Merged your other PR #6831 in the meantime, and now this one has a conflict. |
rebased |
|
Uh oh!
There was an error while loading. Please reload this page.