Merge 11.0_release into master #6799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion (rescript-lang#6763) Print comments inside uncurried arrow function types correctly.
rescript-lang#6766) Handle precedence of uncurried anonymous function in pipe chains. # Conflicts: # CHANGELOG.md
… object and array. Fixes rescript-lang#6789 The issue happens when 2 cases, here `Object` and `Array`, have identical body (here `Console.log(v)`). The switch-generation code, which was not designed with untagged unions in mind, merges the two cases into one (and makes one of the two empty). However, for `Object` and `Array`, what's generated is not a straight switch, but a mix of `if-then-else` and `switch`. This means that the `Object` and `Array` cases are apart in the generated code, and merging them (making one empty) is wrong. # Conflicts: # CHANGELOG.md # jscomp/test/UntaggedVariants.js
# Conflicts: # CHANGELOG.md # jscomp/common/bs_version.ml # jscomp/syntax/src/res_comments_table.ml # jscomp/syntax/src/res_parens.ml # jscomp/test/UntaggedVariants.js # package-lock.json # package.json # packages/std/package.json
cristianoc
approved these changes
May 30, 2024
zth
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates git history and CHANGELOG.