PoC: Type spreads of regular variants in patterns #6720
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
commented
Apr 10, 2024
| let path, decl = Typetexp.find_type env lid.loc lid.txt in | ||
| match decl with | ||
| | {type_kind = Type_variant constructors} -> ( | ||
| (* TODO: Probably problematic that we don't account for type params here? *) |
There was a problem hiding this comment.
This whole fn would be good to get your eyes on @cristianoc . It's mostly copied and adapted to work on regular variants from the existing build_or_pat, that operates on polyvariants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to #6721