Skip to content

Dict as a builtin type #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Dict as a builtin type #6589

wants to merge 6 commits into from

Conversation

zth
Copy link
Collaborator

@zth zth commented Jan 29, 2024

This sets dict up as a builtin type. Preparation for first classing dicts:

  1. Optimize creation so it can compile to a clean instantiation of a JS object Specialize uses of new dict literal to direct JS object creation #6538
  2. Dedicated syntax with spread support and more [RFC] Dedicated syntax for creating Dicts #6545

@cristianoc is this on the right track? See any immediate issues?

@zth zth requested a review from cristianoc January 29, 2024 19:52
@cristianoc
Copy link
Collaborator

Looks fine.
Will also need a one liner in gentype too, similar to this line | ( (["Pervasives"; "result"] | ["Belt"; "Result"; "t"] | ["result"]), in TranslateTypeExprFromTypes for result.

@zth zth changed the base branch from master to 11.0_release January 30, 2024 08:42
@zth zth force-pushed the dict-as-builtin-type branch from 4e6d232 to 59c4720 Compare January 30, 2024 08:45
@cristianoc
Copy link
Collaborator

there seem to be a couple of irrelevant changes, perhaps from merge/rebase

@zth
Copy link
Collaborator Author

zth commented Jan 30, 2024

Yes, trying to sort those now..

@zth
Copy link
Collaborator Author

zth commented Jan 30, 2024

Superseded by #6590

@zth zth closed this Jan 30, 2024
@zth zth deleted the dict-as-builtin-type branch April 29, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants