Skip to content

Set version to 12.0.0-alpha.1 #6557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Jan 10, 2024

I propose to use the master branch for v12 work and create a separate branch 11.0_release (if we keep the existing naming schema) for further 11.0 development/maintenance.

@cknitt cknitt requested review from cristianoc, ryyppy and zth January 10, 2024 17:31
@cristianoc
Copy link
Collaborator

how about merging this as soon as 11.0 is released

@zth
Copy link
Collaborator

zth commented Jan 10, 2024

I'd prefer if we could make a few fairly rapid 11.x or 11.0.x releases, v12 feels like it'll take quite some time to get done. Would be nice to be able to ship a few of the features we want to work on in v11.x. But maybe keeping several branches around and porting/moving fixes between branches is fine.

@cknitt
Copy link
Member Author

cknitt commented Jan 10, 2024

In general, it should be much easier to port fixes between a v12 branch and a v11 branch than it used to be between v11 and v10 (snapshotting, separate syntax repo, ...). As long as they don't diverge too much of course.

Which one we have on master and which one on a separate branch is purely a matter of taste.

If you prefer the next version on master to be set to 11.0.1, this is fine with me, too. I just want to set some version to avoid people appending to the wrong version in the changelog.

@zth
Copy link
Collaborator

zth commented Jan 10, 2024

No I'm fine with this approach if everyone else is, go for it.

@cknitt cknitt merged commit 0bd7367 into rescript-lang:master Jan 12, 2024
@cknitt cknitt deleted the v12-alpha branch January 12, 2024 07:45
shulhi pushed a commit to shulhi/rescript-compiler that referenced this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants