Skip to content

Remove native compilation leftovers from build schema #6474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2023
Merged

Remove native compilation leftovers from build schema #6474

merged 1 commit into from
Nov 6, 2023

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Nov 5, 2023

No description provided.

@cknitt cknitt requested review from cristianoc and zth November 6, 2023 07:06
cristianoc
cristianoc approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these parsed somewhere?
I.e. is there some dead code to remove now?

@cknitt
Copy link
Member Author

cknitt commented Nov 6, 2023

No, not parsed anywhere.

@cknitt cknitt merged commit 6369d60 into rescript-lang:master Nov 6, 2023
@cknitt cknitt deleted the remove-build-schema-leftovers branch November 6, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cknitt @zth @cristianoc