Skip to content

Run gentype tests in CI #6468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2023
Merged

Run gentype tests in CI #6468

merged 1 commit into from
Nov 2, 2023

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Nov 1, 2023

No description provided.

@cknitt cknitt mentioned this pull request Nov 1, 2023
Merged
@cknitt
Copy link
Member Author

cknitt commented Nov 1, 2023

Fails correctly at the moment as gentype tests are broken on master.
Should build once rebased after #6464 is merged.

@cristianoc
Copy link
Collaborator

Would you rebase on master.

cristianoc
cristianoc approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering whether to run gentype tests only when something changes in gentype.
Though the motivating change shows that changes to the compiler itself can be relevant too, so I guess running always is the way to go.

@cknitt
Copy link
Member Author

cknitt commented Nov 2, 2023

Though the motivating change shows that changes to the compiler itself can be relevant too, so I guess running always is the way to go.

Yes, I would run them always for that reason.

@cknitt cknitt merged commit 7e776d0 into rescript-lang:master Nov 2, 2023
@cknitt cknitt deleted the ci-gentype-tests branch November 3, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @cristianoc