Skip to content

Add weird names not found bug test #6367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DZakh
Copy link
Member

@DZakh DZakh commented Aug 26, 2023

I've decided to create a test case for an issue I have. I will try to fix it later, but it's always good to reproduce incorrect behavior beforehand.

Also, I've cleaned up the log a little bit for failing tests.

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this counts a 2 files called "demo" to the compiler.

@cristianoc cristianoc merged commit dfb5b0d into rescript-lang:master Aug 26, 2023
@DZakh DZakh mentioned this pull request Aug 28, 2023
@DZakh
Copy link
Member Author

DZakh commented Sep 22, 2023

I think this counts a 2 files called "demo" to the compiler.

@cristianoc Could you point me to the place where to start looking at? Probably, there should be a map with module names.

@cristianoc
Copy link
Collaborator

I think this counts a 2 files called "demo" to the compiler.

@cristianoc Could you point me to the place where to start looking at? Probably, there should be a map with module names.

Not sure.
The build.ninja file is generated fine, so the order of builds should be OK.
Noticed the issue does not arise if one turns on namespaces "namespace": "my-namespace",
So that difference could be a starting point.

Something to notice is that Demo.test is not a valid module name, so perhaps that's related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants